crew/88fc92b0b821: patchbomb.py fix

Giorgos Keramidas keramida at ceid.upatras.gr
Sun Jun 17 22:32:37 CDT 2007


On 2007-06-17 20:29, Brendan Cully <brendan at kublai.com> wrote:
> On Monday, 18 June 2007 at 06:23, Giorgos Keramidas wrote:
> > > Thanks. I've pushed this much shorter fix:
> >
> > I considered using this form of the fix, but I was unsure about any
> > performance loss caused by going through os.environ[] twice, hence the
> > use of `pager' as an intermediate copy of os.environ['PAGER'] in the
> > original patch.
>
> dict lookup is fast, and this is not a performance-critical piece of
> code :)

Excellent!  I had a hunch this was needless micro-optimization if dict
lookup is fast enough, so thanks once again :-)




More information about the Mercurial-devel mailing list