[RFC] misc small patches

Matt Mackall mpm at selenic.com
Sun Jun 24 11:23:40 CDT 2007


On Sun, Jun 24, 2007 at 05:35:31PM +0200, Markus F.X.J. Oberhumer wrote:
> Matt Mackall wrote:
> >On Sun, Jun 24, 2007 at 01:02:18PM +0200, Markus F.X.J. Oberhumer wrote:
> >>I have prepared a couple of small patches we use in our local mercurial 
> >>versions at 
> >>http://upx.sourceforge.net/download/mercurial-proposed-patches/ .
> >>
> >>Please have a look and feel free to improve/apply, and I can also provide 
> >>proper mercurial diffs on request (still using quilt as I got burned by 
> >>mq serveral times in the past).
> >
> >Some good stuff in there.
> >
> >Please send these to the list, one per message, inline. That way we
> >can review them individually. Also, some of us have workflow tools
> >that depend on stuff arriving by email.
> 
> To save some time, please directly apply the simple one- or two-liners you 
> feel sure about and indicate which of the other patches you would favor or 
> dislike.

I'm not going to pull the patches off your webserver. 

We have a process for accepting patches. They go to the list. They get
commented on. They get archived so they can get easily found again if
they get lost. I have a tool for that and used it to rescue a bunch of
neglected patches just last night.

And they get queued for integration. On my end, it's one keystroke to
queue a patch for later integration, preserving committer name, etc.
Compare that with a bunch of manual cutting, pasting, wgetting,
applying, committing, and you'll see why I'd much rather get
everything by email.

If you want to save time, clone your hg repo, dump your patch queue
into .hg/patches, hg qpush -a, then use hg email (the patchbomb
extension) to mail them all at once. Then delete your clone if you
don't like mq.

-- 
Mathematics is the supreme nostalgia of our time.


More information about the Mercurial-devel mailing list