[issue611] notify: permit diffstats without diffs

Bill Sommerfeld mercurial-bugs at selenic.com
Thu Jun 28 11:21:27 CDT 2007


New submission from Bill Sommerfeld <sommerfeld at sun.com>:

The notify extension optionally attaches diffs to the end of the notification
message, preceded by a diffstat analysis; this can be suppressed if you set
maxdiff=0 in hgrc, but there is no way to get only diffstat without the diff
body, and I'd like that option (maybe just because I'm used to teamware change
notifications including filenames but not diffs..).

The attached patch causes the two tunables (maxdiff and diffstat) to be
independent; if diffstat is set to true but maxdiff is zero, you see diffstat
but not diff output.

this is admittedly an incompatible behavior change (albeit a change to output
intended primarily for human consumption); a compatible change would introduce a
new configuration boolean or tweak the behavior (perhaps making the default
diffstat value dependent on the value of maxdiff; before this change it would
not make sense to explicitly set diffstat = True while maxdiff = 0).

It appears to work for me but I am just stumbling around learning python.

----------
files: notify-diffstat-without-diffs
messages: 3391
nosy: sommerfeld
priority: feature
status: unread
title: notify: permit diffstats without diffs

____________________________________________________
Mercurial issue tracker <mercurial-bugs at selenic.com>
<http://www.selenic.com/mercurial/bts/issue611>
____________________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: notify-diffstat-without-diffs
Type: application/octet-stream
Size: 1203 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20070628/1a10d431/attachment.obj 


More information about the Mercurial-devel mailing list