[PATCH] Added new send extension

Matt Mackall mpm at selenic.com
Wed Mar 21 23:57:31 CDT 2007


On Wed, Mar 21, 2007 at 09:45:38PM -0500, John Goerzen wrote:
> On Wed, Mar 21, 2007 at 07:30:48PM -0500, Matt Mackall wrote:
> > > +    # present on windows
> > > +    import readline
> > > +except ImportError: pass
> > 
> > We're pretty consistent about doing a line break after colons.
> 
> On this and a lot of the other style questions, I have no problem
> changing, but I should say I was following the style in patchbomb.py.
> Some of the things you highlighted -- such as the above -- were actually
> literally copied and pasted from it.  Would you like me to fix my code,
> and also send in patches to fix the same things in patchbomb.py?

Sure. But the more I think about it, I think we probably want this to
be part of patchbomb so that we only have one email command.

Let's think about how to do that. Here are the current email options:

 -a --attach    send patches as inline attachments
    --bcc       email addresses of blind copy recipients
 -c --cc        email addresses of copy recipients
 -d --diffstat  add diffstat output to messages
 -g --git       use git extended diff format
 -f --from      email address of sender
    --plain     omit hg patch header
 -n --test      print messages that would be sent
 -m --mbox      write messages to mbox file instead of sending them
 -s --subject   subject of first message (intro or single patch)
 -t --to        email addresses of recipients

Also add the --outgoing that Brendan's working on. And I believe your
version adds --base and -r. So now we need a -b/--bundle option.

So for patch style, we can use -a, -d, -g, and --plain. For bundles,
we can use -b, --base, and -r. The other options apply to both modes.
For projects which always want bundles, people can add -b to their
.hg/hgrc.

-- 
Mathematics is the supreme nostalgia of our time.


More information about the Mercurial-devel mailing list