[PATCH] Check case-folding clashes during addremove

Matt Mackall mpm at selenic.com
Thu Mar 29 00:49:40 CDT 2007


On Thu, Mar 29, 2007 at 09:58:56AM +0400, Andrei Vermel wrote:
> >This really should go into dirstate.py, so that hg add can also benefit
> >from it.  If you look at the dirstate.update function, you'll see that
> >we already do some checks when state == 'a' (i.e. we're adding a file).
> 
> There's a small problem with this. Although dirstate.update() takes 'files',
> turns out it is called for each file separately. Rebuilding the name clash
> map for each added file would be an overhead for big number of added
> files.
> As an option, the clash map can persist in dirstate and get updated
> incrementally with dirstate.map. What do you think?

Yes, definitely.

-- 
Mathematics is the supreme nostalgia of our time.


More information about the Mercurial-devel mailing list