[PATCH] Re: crew fails to build on Solaris

Giorgos Keramidas keramida at ceid.upatras.gr
Mon Oct 15 04:43:16 CDT 2007


On 2007-10-12 15:05, Matt Mackall <mpm at selenic.com> wrote:
> On Fri, Oct 12, 2007 at 12:45:44PM -0700, Bryan O'Sullivan wrote:
> > Giorgos Keramidas wrote:
> >
> > > osutil.c: DIR->dd_fd is not a public interface on Solaris
> >
> > The original code builds just fine on Solaris 10.  It would be useful to
> > know when that stuff was introduced into Solaris, so the ifdefs can be
> > more carefull parameterised.
>
> I've dropped the fstatat bits in the current tip for now under the
> theory that they weren't worth the trouble. But it seems they're a
> non-negligible performance improvement here, so they ought to go back
> in if we can figure out how to make it build everywhere.

bos@ has a patch which fixes the build on FreeBSD and Solaris, but keeps
the fstatat() bits :-)



More information about the Mercurial-devel mailing list