[PATCH] Catch smtp exceptions

Matt Mackall mpm at selenic.com
Fri Oct 19 17:00:13 CDT 2007


On Fri, Oct 19, 2007 at 10:39:01PM +0200, Christian Ebert wrote:
> * Matt Mackall on Friday, October 19, 2007 at 13:43:32 -0500
> > On Fri, Sep 07, 2007 at 04:50:25PM +0200, Christian Ebert wrote:
> >> --- a/hgext/patchbomb.py
> >> +++ b/hgext/patchbomb.py
> >> @@ -411,7 +411,8 @@ def patchbomb(ui, repo, *revs, **opts):
> >>             ui.status('Sending ', m['Subject'], ' ...\n')
> >>             # Exim does not remove the Bcc field
> >>             del m['Bcc']
> >> -            mailer.sendmail(sender, to + bcc + cc, m.as_string(0))
> >> +            mail.sendmail(ui, sender, to + bcc + cc, m.as_string(0),
> >> +                          mailer=mailer)
> > 
> > This change looks suspicious?
> 
> Perhaps I had to much respect for the existing structure of
> patchbomb. Here's another version, simpler and cleaner imho:

Applied, thanks.

-- 
Mathematics is the supreme nostalgia of our time.


More information about the Mercurial-devel mailing list