[PATCH] Allow ssh.cmd, ssh.opts to be used in [ui]

Steve Borho steve at borho.org
Thu Sep 6 15:30:41 CDT 2007


On Thu, 2007-09-06 at 13:05 -0700, Brendan Cully wrote:
> On Thursday, 06 September 2007 at 15:06, Steve Borho wrote:
> > # HG changeset patch
> > # User Steve Borho <steve at borho.org>
> > # Date 1189108606 18000
> > # Node ID f2eca1509bde4a3b1990781c07274ae6de2e3a0b
> > # Parent  f8c36b215281a7e8f3aaed632206d3627ee21e6e
> > Allow ssh.cmd, ssh.opts to be used in [ui]
> > 
> > Example .hgrc section:
> > 
> > [ui]
> > ssh.cmd = C:\Program Files\Mercurial\plink.exe
> > ssh.opts = -ssh -i \path\to\key
> 
> What's this for? Can't we just use shlex and:
> 
> ssh = "C:\Program Files\Mercurial\plink.exe" -ssh -i \path\to\key

Yes, shlex looks like it would be much simpler solution to this problem.
I can submit a new patch that removes the new config options and simply
fixes the existing behavior.

-- 
Steve Borho (steve at borho.org)
http://www.borho.org/~steve/steve.asc
Key fingerprint = 2D08 E7CF B624 624C DE1F  E2E4 B0C2 5292 F2C6 2C8C




More information about the Mercurial-devel mailing list