record extension - where's diff option?

Brendan Cully brendan at kublai.com
Thu Sep 6 19:48:28 CDT 2007


On Friday, 07 September 2007 at 01:42, TK Soh wrote:
> On 9/6/07, Patrick Mézard <pmezard at gmail.com> wrote:
> > Alan D. Salewski a écrit :
> > > On Thu, Sep 06, 2007 at 11:54:11AM -0400, Neal Becker spake thus:
> > >> hg record SConscript
> > >> diff --git a/mod/SConscript b/mod/SConscript
> > >> 1 hunks, 12 lines changed
> > >> record changes to 'mod/SConscript'? [Ynsfdaq?]  ?
> >
> > [...]
> >
> > > Actually, the above prompt is really just asking you if you want to
> > > consider /any/ of the changes for that file. If you respond with 'y',
> > > you'll then be prompted to accept or reject the individual patch hunks.
> > > If you say 'n', then the 'record' extension will move on to the next
> > > changed file (if any).
> >
> > Maybe we should change it to "review changes to 'mod/Sconscript'? ..."
> 
> IMO, hg record is really meant for cherry-picking part of the changes
> you want to commit. Reviewing changes should be done with hg
> diff/extdiff.

The idea is just not to have to wade through 10 chunks to a file you
aren't going to be committing. It's sort of an interactive -I/-X or
file pattern. I can understand it given that the whole point of record
is to be interactive, but maybe pruning the list by patterns would
have sufficed.


More information about the Mercurial-devel mailing list