[PATCH] ssh: use shlex to parse command line

Patrick Mézard pmezard at gmail.com
Sat Sep 8 15:55:17 CDT 2007


Steve Borho a écrit :
> ... which looks pretty good.  It seems os.popen3() is successfully
> parsing the ssh command name, but the rest of the argument parsing
> (probably a function of the windows shell) is broken.

What about the attached patch (against crew-stable) ?

Tests pass under windows and macosx but they do not exercize it very 
much and it's hard to build one not looking too kludgy. I think quoting 
all arguments should be harmless under unix but I may be wrong.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: quote-ssh.diff
Url: http://selenic.com/pipermail/mercurial-devel/attachments/20070908/88758a4f/attachment.txt 


More information about the Mercurial-devel mailing list