[PATCH] ssh: use shlex to parse command line

Patrick Mézard pmezard at gmail.com
Mon Sep 10 17:01:51 CDT 2007

Alexis S. L. Carvalho a écrit :
> Thus spake Patrick Mézard:
>> Steve Borho a écrit :
>>> ... which looks pretty good.  It seems os.popen3() is successfully
>>> parsing the ssh command name, but the rest of the argument parsing
>>> (probably a function of the windows shell) is broken.
>> What about the attached patch (against crew-stable) ?
> One alternative that wouldn't require shlex would be to just add some
> util.quotecommand function that adds the extra quotes on windows.  From
> the user POV, he'd use the same syntax from the [hooks] section (i.e.
> system-specific quoting instead of shlex quoting).  Somthing like this:

Pushed your version in crew-stable and crew as 5a65d870871d.

Patrick Mézard

More information about the Mercurial-devel mailing list