[patch] syntax:plain for .hgignore

Jonathan S. Shapiro shap at eros-os.com
Wed Sep 12 04:59:14 CDT 2007


On Tue, 2007-09-11 at 15:26 -0500, Matt Mackall wrote:
> On the other hand, if your regex is too large for your Python build
> and it has to get broken into pieces, then regexes will probably lose.

I don't know how python implements regexes, but this statement surprises
me. I would have expected the regex internal data structure to be
dynamically allocated, and not to have much in the way of a size limit.
Does python fragment the regex internally in some cases?

The other thing I found suspicious in that profile was the high cost of
method dispatch:

          5874      1.7714      1.7714   <built-in method match>

I'm thinking that maybe hg isn't actually *building* the grand regexp?

It would sure be great if this all turned out to be a regexp
construction bug. :-)

shap



More information about the Mercurial-devel mailing list