[patch] syntax:plain for .hgignore

Jonathan S. Shapiro shap at eros-os.com
Wed Sep 12 13:27:48 CDT 2007


On Wed, 2007-09-12 at 13:10 -0500, Matt Mackall wrote:
> Trouble is, the limiting factor is not the number of lines, but the
> number of graph nodes in the resulting NFA. So without parsing the
> regex ourselves, we really don't know whether a given set of lines
> will overflow the engine until we try.

I realize this. I'm suggesting that the process of dynamic convergence
may be more expensive than simply running smaller REs -- even if you
might hypothetically have obtained larger ones.

> > But the main thing is the 5000 calls to sre.compile!
> > 
> > Is it possible that the culprit is the call to matchfn() around
> > util.py:467 that is building filematch?
> 
> Which? This?
> 
>     patmatch = matchfn(pats, '$') or always

No. The one right below that that builds filematch. Possible that is
getting called with a very large list? Like maybe the list of all 12,000
or so of his file names?
-- 
Jonathan S. Shapiro
Managing Director
The EROS Group, LLC
www.coyotos.org, www.eros-os.org



More information about the Mercurial-devel mailing list