[PATCH 2 of 3] Rename util.checkfolding to util.case_sensitive_fs

Matt Mackall mpm at selenic.com
Thu Apr 10 09:51:52 CDT 2008


On Thu, 2008-04-10 at 09:10 +0200, Gilles Moris wrote:
> 4 files changed, 4 insertions(+), 4 deletions(-)
> hgext/purge.py        |    2 +-
> mercurial/commands.py |    2 +-
> mercurial/merge.py    |    2 +-
> mercurial/util.py     |    2 +-
> 
> 
> # HG changeset patch
> # User Gilles Moris <gilles.moris at free.fr>
> # Date 1207810213 -7200
> # Node ID c0d7019014b4a2f605c78853aabfc03a243938d3
> # Parent  1bd769993474e4b9131e228658f9d113adbedc97
> Rename util.checkfolding to util.case_sensitive_fs

No thanks. We've got three filesystem feature checking functions:
checkfolding, checkexec and checklink. Changing just one of them to
something other than check* is definitely the wrong thing to do. Adding
underbars even moreso.

Now if you're trying to tell us that the name doesn't match the behavior
of the function, you should just say so. And then I'd say, yes, you're
probably right, we are in fact checking if the FS -doesn't- do folding.
We can either reverse the output of the function or rename it. I'd lean
towards renaming it as I think of case-sensitivity as the right answer,
the one we should return true for. It should in fact be named
checknonfolding or checkcasesensitive or (what I'd prefer) checkcase.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list