[PATCH 2 of 3] Resolve issue 1092 (case clash in hg add)

Emanuele Aina emanuele.aina at gmail.com
Mon Apr 28 12:39:33 CDT 2008


Paul Moore sistemò:

> 2008/4/23 Matt Mackall <mpm at selenic.com>:
> >  >      for src, abs, rel, exact in cmdutil.walk(repo, pats, opts,
> >  >                                               badmatch=util.always):
> >  > +        abs = util.filesystem_case(abs)
> >
> >  Seems this should be done in cmdutil, or even lower? Perhaps
> >  dirstate.statwalk?
> 
> You're quite possibly right. When I initially tried putting it lower,
> it broke some other things. I think things partway up the stack are
> expecting to be able to use == on filenames (which isn't valid on case
> insensitive systems). I'll try again based on your suggestions.

If you can fix the issue directly in dirstate.statwalk() it will make
the 'purge' extension usable even on name-mangling filesystems.

If only upper levels will get fixed 'purge' will not be able to benefit
from the fix as only dirstate.statwalk() is able to yield directories
during the walk...

-- 
Buongiorno.
Complimenti per l'ottima scelta.



More information about the Mercurial-devel mailing list