[PATCH 0 of 3] fix for issue1228 and issue1182

Patrick Mézard pmezard at gmail.com
Sat Aug 2 16:54:18 CDT 2008


Bernhard Leiner a écrit :
> reworked patchset that hopefully addresses all of Patricks remarks.

Excellent !

Pushed: http://hg.intevation.org/mercurial/crew/rev/8f256bf98219

I edited a couple of lines of the main patch:
- Fixing typos in the docstring
- Shortening the changelog message
- Replacing nodes[0] by a node variable
- Wrapping best_node in a list after assigning it.

I consider these minor fixes compared to the whole contributions, and decided to do them without requesting another roundtrip. I added a note at the end of the changelog so you can blame me if you are unhappy with the changes. Hope that won't happen.
 
> Additionally, I added a new test-bisect2 file that uses a non-linear history for a couple of bisect tests.

Good. I am a bit worried about the test complexity, but we could just drop it if it's too hard to maintain.

Thanks for the patches !

--
Patrick Mézard


More information about the Mercurial-devel mailing list