[PATCH] Fix for Issue1260

Shun-ichi GOTO shunichi.goto at gmail.com
Fri Aug 15 12:37:49 CDT 2008


2008/8/16 Adrian Buehlmann <adrian at cadifra.com>:
>> Please use util.pconvert(base) or util.normpath(base) instead of using
>> string.replace() directly.
>> This is due to MBCS issue (regarding to hgext/win32mbcs.py).
>>
>
> Are you sure that you want to tweak the paths inside .hg/store
> with the win32mbcs extension?

No, it is not intended.
But your fix means 'base' argument may have '\\' path sep char
and it means 'base' is local path bytes, not normalized path.
I guess you want to replace '\\'  for normalization.
I mentioned that we should use util.pconvert() for normalization
in whole of mercurial code.
As result, it brings a benefit for win32mbcs users.

-- 
Shun-ichi GOTO


More information about the Mercurial-devel mailing list