[issue1278] ssh push hangs when changegroup hook restarts daemon (amavisd)

[Thomas Arendsen Hein]

New submission from Thomas Arendsen Hein <thomas at intevation.de>:

Related to issue706 (hooks shouldn't interfere with the wire protocol),
so copying nosy from there:

In a repo I push to I always had something like the following line in .hg/hgrc:
changegroup = { hg co && /etc/init.d/amavisd restart; } >&2

This worked fine until I upgraded the server from 0.9.5 to 1.x, now it hangs
after printing:
pushing to ssh://example.com//repo
searching for changes

When manually looking at the target repo, the changesets are there.

Dropping any useful combination of "hg co", "{ ...; }" or >&2 does not help.
Even using >/dev/null 2>&1 does not help.

bisect shows:
The first bad revision is:
changeset:   6266:9f76df0edb7d
user:        Alexis S. L. Carvalho <alexis at cecm.usp.br>
date:        Fri Mar 14 21:57:46 2008 -0300
summary:     hook.py: fix redirections introduced by 323b9c55b328

Could it be that amavisd closes stdin/out/err when daemonizing and Mercurial is
affected by this?

----------
messages: 6862
nosy: ThomasAH, alexis, djc, kupfer, sborho
priority: bug
status: unread
title: ssh push hangs when changegroup hook restarts daemon (amavisd)
topic: ssh_proto

____________________________________________________
Mercurial issue tracker <mercurial-bugs at selenic.com>
<http://www.selenic.com/mercurial/bts/issue1278>
____________________________________________________