[PATCH] walkrepo: recurse only if ** in [paths] or [collections]

[Dirkjan Ochtman]

On Tue, Dec 9, 2008 at 09:44, Ben <benoit.allard at gmx.de> wrote:
> We're having a political issue there as the release note for 1.1 is
> mentioning recursive collections. As for now, path = '*' or '**' are
> behaving recursively, the former could be considered as s bug and
> corrected into flat discovery. But I'm afraid we'll have to keep the
> CompatibilityRules on collections.

Well, I think the slowness for large, checked-out repos is pretty bad,
so I think that takes precedence. Let's make the recursive walking (a
nice-to-have feature, but really not a necessary thing IMO) explicitly
opt-in by requiring ** (which also gives people a chance to move from
collections to the new-style paths). If we get this into a 1.1.1
soonish, I think the backwards compatibility damage is minimal; none
of the large users have switched anyway, and it also means we unbreak
a lot of people's slowish collections.

Cheers,

Dirkjan