patch.py - bug and patch

Benoit Boissinot bboissin at gmail.com
Sat Dec 13 09:48:54 CST 2008


[sorry for the resend, forgot to reply-all]

On Sat, Dec 13, 2008 at 04:28:51PM +0100, Bartosz SKOWRON wrote:
> On Sat, Dec 13, 2008 at 1:14 PM, Benoit Boissinot <bboissin at gmail.com> wrote:
> 
> > Patrick, did you have a look at this? A potential concern might be that
> > the previous code was working for some unusual patch headers whereas
> > this one is more constrained (but obviously the previous code wasn't
> > working for filenames with embedded spaces).
> 
> What do you mean by unsual patch? From universe? ;)

There are a lot of stuff creating patch headers (all VCSs, GNU and
non-GNU diff, etc).
> 
> > +----------------------------------------------------------------------
> > +Ran 1 test in 0.000s
> >
> > This seems bogus (the output would likely depend on the load of the
> > computer.
> 
> Yeah! If you are tonfa on IRC (are you?), then i showed the funny log
> with this.

Yes I am :)

> Like test failed because in *.out was 0.000s but in real
> test got 0.002s ;) IMHO mercurial's test framework sucks in this way,
> it shouldn't depends on the time.
> Also, Patrick asked me after first version of patch to make it
> possible to run in 0.000s, not 0.002s.

Then we need to find a way to change the output to exclude timing
results (at least when run via run-tests.py).

regards,

Benoit

-- 
:wq


More information about the Mercurial-devel mailing list