[PATCH 0 of 1] diffstat implementation in python

Dirkjan Ochtman dirkjan at ochtman.nl
Sun Dec 21 08:34:03 CST 2008


On 21/12/2008 10:54, Alexander Solovyov wrote:
> This is python implementation of diffstat, which makes it work much faster
> on small patches (no overhead of calling a system program) and removes
> dependency on 'diffstat' program. Additionally it is possible to retrieve
> collected information through an attributes of a diffstat object, which
> removes a need to parse diffstat output if anyone will need it.

Since we don't use the diffstat code in any very critical places, and 
the Python code seems fast enough even for large patches, this is 
probably a good idea, and I don't think we need an optional call-out to 
the external diffstat (which helps compatibility, too). So, +1.

Not sure yet on whether this should just be a simple string-returning 
function rather than a whole class, though.

Cheers,

Dirkjan


More information about the Mercurial-devel mailing list