[PATCH] Warn in case user tries to add files which would otherwise be ignored

Matt Mackall mpm at selenic.com
Fri Feb 22 19:41:56 CST 2008

On Fri, 2008-02-22 at 17:45 -0500, Jesse Glick wrote:
> Alexis S. L. Carvalho wrote:
> >> if a novice user runs 'hg add module/*' then generated-file is
> >> added with no warning!
> > 
> > FWIW this shouldn't happen anymore after b41f0d6a74fc.
> I did notice a change since 0.9.5, though I didn't track it back to this 
> revision. Good to know. Which behavior is correct in this case is hard 
> to judge, I guess - if the user said 'hg add module/build' presumably 
> they meant it, whereas if 'hg add module/*' then presumably not; but 
> Mercurial only gets the expanded argument list.
> > (But "hg add module/build/*" will still add things).
> Right, which can be observed in the test.

So is this patch really needed? I'd prefer not to add it as there's a
common "ignore everything but what's explicitly added" usage model.

Mathematics is the supreme nostalgia of our time.

More information about the Mercurial-devel mailing list