[PATCH] add explicit extension disabling syntax to hgrc.5

Thomas Arendsen Hein thomas at intevation.de
Wed Feb 27 02:03:42 CST 2008


* Adrian Buehlmann <adrian at cadifra.com> [20080227 00:42]:
> On 26.02.2008 22:14, Patrick Mézard wrote:
> > Steve Borho a écrit :
> >> # HG changeset patch
> >> # User Steve Borho <steve at borho.org>
> >> # Date 1204028711 21600
> >> # Node ID 96ef88ccbcb0e790b25f5c4eecbe2bd29033287e
> >> # Parent  434139080ed4007d99e843b203c7da0850238744
> >> add explicit extension disabling syntax to hgrc.5
> > 
> > Slightly edited and pushed in crew as 7f9f3233a2c6. Thanks !
> 
> So I wonder why you didn't make two changesets of this.
> One with Steve's original patch, followed by your edit.
> 
> Just an observation. Possibly a very bad example here since your edit
> is certainly good. But for me it looks a bit like someone signs
> something using the signature of somebody else. A bit like using
> the wrong sender address in an email. Something I really wouldn't like
> to do myself.

Usually if it is more than fixing a typo it will be a separate
patch. In this particular case Steve said on IRC that we should feel
free to extend it a little bit to make path vs. no path clearer.

So this is just a shortcut for "Steve, please change this for that
and make a new patch".

> On another note, it seems that repository pullers will never know who
> pushed the change into crew by looking into the crew repo alone.
> An information that would be nice to have as well.

Sometimes I miss that, too, and already thought about adding this
information to the notifications :) This wouldn't be part of the
changeset history of course.

Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Osnabrueck - Register: Amtsgericht Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Mercurial-devel mailing list