[PATCH] hg tag: run tag hook just once

Matt Mackall mpm at selenic.com
Fri Jan 4 10:39:01 CST 2008


On Fri, 2008-01-04 at 16:08 +0100, Thomas Arendsen Hein wrote:
> * John Coomes <John.Coomes at sun.com> [20080104 11:16]:
> > I (John.Coomes at sun.com) wrote:
> > > Here's the standalone patch to remove the extra call to the tag hook
> > > for global tags.
> > > ...
> > 
> > Here's the patch again, this time applied to the current hg-stable.
> > Let me know if anything else is needed (e.g., file a bug).
> 
> Your original patch was pushed to the main repository.
> 
> I think it was mpm who applied it, so there are two possibilities
> why it isn't in hg-stable:
> 1. It was just forgotten or
> 2. The one who applied it thought that it isn't suitable for stable,
>    because it changes the hook behaviour and there might be people
>    who rely on this bug. These people shouldn't have to remove their
>    workaround during a stable update.
> 
> John, can you live with the fact that the fix isn't in stable?
> mpm, was it just forgotten and should be applied to stable?
> 

It ought to go in stable. I just got distracted by the various other
cleanups we should probably do to the tag code.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list