[PATCH 3 of 5] Add util.splitpath() and use it instead of using split() directly

Shun-ichi GOTO shunichi.goto at gmail.com
Tue Jan 8 17:24:30 CST 2008


2008/1/9, Matt Mackall <mpm at selenic.com>:
> [re-adding list]

# sorry, my mistake

> On Tue, 2008-01-08 at 16:24 +0900, Shun-ichi GOTO wrote:
> > 2008/1/8, Matt Mackall <mpm at selenic.com>:
> > > Here's a big question that we have to answer with regard to MBCS: what
> > > happens if you check in a path with a 0x5c on a shift-jis machine and I
> > > check it out in ascii-land? I suspect the answer is: I get an extra
> > > directory level and much confusion.
> >
> > Is this question for the behaviour on patched mercurial?
> > Or for current hg?
> >
> > If former, the people in ascii-windows-land may gets confuzed
> > by error.
> > The pepole asii-unix-land people are good to play, no extra directory.
> >  This is limitation of my patch
> > first I described in [PATCH 0 of 5],  "effects and save local only".
>
> How does it work? What byte sequence gets stored in the manifest?

??
shift_jis encoded bytes in manifest.


> a) do the os.sep and split cleanups like you already posted
> b) in your extension, wrap the various built-ins and library functions
> that report paths
> c) add shift-jis <-> utf-8 to util.pconvert and util.localpath

I'll see and try for that way.

-- 
Shun-ichi GOTO


More information about the Mercurial-devel mailing list