[PATCH 1 of 1] convert should use default value when CVS_RSH is not set, that value being 'ssh'

Mads Kiilerich kiilerix at gmail.com
Wed Jan 16 17:33:52 CST 2008


Bryan O'Sullivan wrote, On 01/15/2008 05:14 PM:
> Konstantinos Koukopoulos wrote:
> 
>> convert should use default value when CVS_RSH is not set, that value 
>> being 'ssh'.
> 
> Applied, thanks.

All right; cvs cvs trunc defaults to ssh - according to
http://cvs.savannah.gnu.org/viewvc/cvs/ccvs/configure?revision=1.487&view=markup

But in cvs-1.11.22 (which is found in Fedora 8) the default is rsh - see 
http://cvs.savannah.gnu.org/viewvc/cvs/ccvs/configure.in?revision=1.176.2.69&view=markup&pathrev=cvs1-11-22

However, on fedora /etc/profile.d/cvs.sh contains
	export CVS_RSH=${CVS_RSH-ssh}

So, on Fedora 8, even with this change, if someone really uses rsh and 
thus has unset CVS_RSH, then the conversion will try to use ssh and fail.

Similar issues may exist for a long time on other OS'or distributions.

I think the change is fine anyway, and if someone is hit by it then I 
hope they will find this message ;-)

/Mads


More information about the Mercurial-devel mailing list