[PATCH] tests: Use /bin/sh for test-journal-exists, /bin/bash may not be available

Giorgos Keramidas keramida at ceid.upatras.gr
Thu Jan 17 19:30:11 CST 2008


On 2008-01-17 19:19, Matt Mackall <mpm at selenic.com> wrote:
> On Fri, 2008-01-18 at 03:06 +0200, Giorgos Keramidas wrote:
> > tests: Use /bin/sh for test-journal-exists, /bin/bash may not be available
> >
> > diff --git a/tests/test-journal-exists b/tests/test-journal-exists
> > --- a/tests/test-journal-exists
> > +++ b/tests/test-journal-exists
> > @@ -1,4 +1,4 @@
> > -#!/bin/bash
> > +#!/bin/sh
>
> Oops, my fault. Queued. Anyone feel like hacking together a script to
> test for common errors like these?

I'm always running the test suite after pulling from crew, on FreeBSD,
Solaris and Linux.  The combination of these OSes, different Python
versions and a few local differences, is a fairly good measure of the
portability of the tests we have now.

It would be nice if we could run something like:

	python check-tests.py

and have it report common errors though.  How would you go about copying
the run-tests.py logic for iterating through the tests, and map each
test through a series of 'validating' mini-checks?



More information about the Mercurial-devel mailing list