[PATCH] qrefresh += --amend (#933)

Kirill Smelkov kirr at landau.phys.spbu.ru
Fri Jan 18 17:23:07 CST 2008


On Fri, Jan 18, 2008 at 04:50:26PM -0600, Matt Mackall wrote:
> 
> On Fri, 2008-01-18 at 22:42 +0300, Kirill Smelkov wrote:
> > # HG changeset patch
> > # User Kirill Smelkov <kirr at mns.spb.ru>
> > # Date 1200685207 -10800
> > # Node ID 48fa1430786a31d4e31d80832c4d9215268e25e4
> > # Parent  fb93c774dffff3601835102fdb57417428307cba
> > qrefresh += --amend  (#933)
> > 
> > It would be handy to say 'hg qrefresh file.txt' to add changes made to file.txt
> > to current patch.
> > 
> > Unfortunately this is not qrefresh behaviour -- it just excludes everything but
> > file.txt from refreshed patch. We discussed this on irc, and it seems people
> > are against changing this behaviour becuase of backward compatibility.
> 
> Interesting - was this really the expected behavior? I guess so - that's
> how it's documented. Queued.

In fact I'm for qrefresh to behave the --amend way by default. I'd also
vote for it to be the only way, and if one wants to exclude a file from
patch to do it with some option/command etc -- because present behaviour
of 'hg qrefresh file.txt' is *confusing*.

Also, it seems my patch is wrong :(
Please unqueue it.

P.S. I think what we really need is to 'hg qnew -f' do not include any
changes in the patch -- so there woudn't be a need to exclude files
later.

-- 
    Всего хорошего, Кирилл.
    http://landau.phys.spbu.ru/~kirr/aiv/


More information about the Mercurial-devel mailing list