[PATCH take 2] Making the gitweb annotate page look more like git's

Thomas Arendsen Hein thomas at intevation.de
Wed Jan 23 02:50:32 CST 2008


* Govind Salinas <blix at sophiasuchtig.com> [20080123 05:36]:
> # HG changeset patch
> # User Govind Salinas <blix at sophiasuchtig.com>
> # Date 1201062132 21600
> # Branch gitweb3
> # Node ID e223145828cc696925d67e7beb4aea03788fb3ab
> # Parent  d0576d065993c59f0e84b6e71e2690531e825574
> Making the gitweb annotate page look more like git's

> +                       "lineno":lineno,
> +                       "revparity":revparity,
> +                       "samerev":samerev,
> +                       "revdate":f.date()}

Please use spaces after colons.

Additionally you could try to use the same code as
filerevision().lines() does (enumerate) to get the line numbers, and
please call it "linenumber" for consistency.

(though a grep showed me that we already have a bunch of linenr and
lineno in the templates ...)

> +<script type="text/javascript">
> +function toggle_extra_columns()

Not really sure about that, this would be the first introduction of
javascript, and probably not for an important reason (unlike e.g.
the branchview code).

Is this javascript code from gitweb?

I haven't tried it, how will this be rendered if js is disabled or
not available?

There is already toggle code in hg for the sorting of columns on the
index page, maybe you can try something like this. Bonus points if
this is reusable as a generic --verbose switch :)

Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Osnabrueck - Register: Amtsgericht Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Mercurial-devel mailing list