[issue956] gpg: doesn't accept a negative integer as a revision

Wagner Bruna mercurial-bugs at selenic.com
Wed Jan 30 17:24:26 CST 2008


New submission from Wagner Bruna <wagner.bruna+mercurial at gmail.com>:

The gpg extension doesn't use an option for revision specifiers, so negative
integers are parsed as options:

  [/tmp]$ hg --version
  Mercurial Distributed SCM (version 0.9.5)
  [/tmp]$ hg init test
  [/tmp]$ cd test
  [/tmp/test]$ touch test
  [/tmp/test]$ hg ci -A -m 'test'
  adding test
  [/tmp/test]$ hg sigcheck tip
  No valid signature for c2de9f8be519
  [/tmp/test]$ hg sigcheck -1
  hg sigcheck: option -1 not recognized
  hg sigcheck REVISION

  verify all the signatures there may be for a particular revision

  use "hg -v help sigcheck" to show global options

A '--' helps:

  [/tmp/test]$ hg sigcheck -- -1
  No valid signature for c2de9f8be519

but AFAICS this usage isn't documented.

I attached a patch for sigcheck and sign accept '-r' for the revisions. For
compatibility's sake it still accepts revisions entered directly.

----------
files: gpg_negative_rev.patch
messages: 5043
nosy: wbruna
priority: bug
status: unread
title: gpg: doesn't accept a negative integer as a revision

____________________________________________________
Mercurial issue tracker <mercurial-bugs at selenic.com>
<http://www.selenic.com/mercurial/bts/issue956>
____________________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gpg_negative_rev.patch
Type: text/x-diff
Size: 1701 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20080130/6c05d48f/attachment.patch 


More information about the Mercurial-devel mailing list