[PATCH 2 of 3] move store walking from streamclone.py into store.py

[Dirkjan Ochtman]

Adrian Buehlmann <adrian <at> cadifra.com> writes:
> Is there anything left I can do for patch 1 and 2,
> so that at least these two patches could be included
> or should this work be dropped together with patch 3?

Patch 1 and 2 look good to me, too, but I have one minor improvement that I
think would make sense: instead of having storefiles() catch LockHeld and
LockUnavailable and returning a sentinel value to indicate whether that call
succeeded, why not just let them throw some exception? I'm currently on the
fence about whether it should just raise the lock exceptions to the caller (just
streamclone, I think), or catch the lock exceptions and raise something else.
That would also allow for eliminating the first element of the return tuple, I
think. Does that make sense?

Otherwise, I think you wanted to fold some stuff from patch 3 into 2, but it
looks very nice!

Cheers,

Dirkjan