[PATCH] Support MBCS for fspath() and checkcase()

Shun-ichi GOTO shunichi.goto at gmail.com
Mon Jul 28 08:44:51 CDT 2008


2008/7/28 Paul Moore <p.f.moore at gmail.com>:
> This seems reasonable - I introduced checkcase and fspath, and never
> considered MBCS support, so doing the same as for the other functions
> seems like the right approach (based on my complete lack of knowledge
> of the subject!)

I think fspath() is the first case of converting path, so there is no existing
right approach here.

fspath() would work well except using semi-problematic encoding
which has ASCII code in 2nd (or later) byte  (like shift_jis).
So I think one solution is saying: "do not use such a encoding,
or use win32mbcs for workaround with some limitation."

The limitation of using win32mbcs is actual path encoding and locale
should be match in any time because it does the coding conversion.
Also you cannot mix the encodings (I guess no one does so).

I don't have other idea yet.

# So please accept the patch.
-- 
Shun-ichi GOTO


More information about the Mercurial-devel mailing list