[PATCH 0 of 3] convert: Built-in cvsps for hg cvs import (6).

[Frank A. Kingswood]

Patrick Mézard wrote:
> I have not really used it but given the amount of work you put in and the overall feedback, I am for the inclusion in Mercurial if the following points are resolved:
> 
> 1- Coding style is incorrect in cvs.py, I will annotate the message.
> 2- Coding style of cvsps and cvsps.py do not follow Mercurial style (same remarks as in [1]). I find it annoying but won't fight against it if others are OK with it. What's blocking for me is the identation, I dislike having one differing from the python standard of 4 spaces per tab. Not everybody is a wizard at editor configuration, it's good to follow this convention.

OK. From your other message that boils down to whitespace only.

> 3- The new tests do not pass under Windows, the error output is copied below.
[...]
 > +cvs server: cvs checkout: cannot find module 
`src/c:\docume~1\trick\locals~1\temp\hgtests.qjk7mu\test-convert-cvs-branch\cvsrepo/src/a' 
- ignored
 > +
 > +abort: unknown CVS response: error

After the CVS checkout fails obviously we're dead.

I do not have access to a Windows machine to try this on, but I can 
guess that if this is a slash vs backslash issue. Can you help debug the 
script on Windows? Are you running with cygwin CVS or native?

Frank