[PATCH 0 of 6] Refactor localrepo.commit() to read from changectx

Paul Moore p.f.moore at gmail.com
Sun Jun 15 13:08:41 CDT 2008


2008/6/15 Patrick Mezard <pmezard at gmail.com>:
> I would like to have some feedback about this approach before starting with the
> memctx and refactoring convert.

I'm not particularly qualified to comment on the changes themselves,
but from an earlier comment I understand that one of the implications
here is that the convert extension will not need to use the working
directory as "intermediate storage". I am strongly in favour of this,
as I think it was at the root of an issue I had a while ago, where a
Subversion repo I was tracking gave me some problems because of case
clashes. Doing the conversion in stages seemed to resolve the issue,
and I suspect it was caused by the dirstate not being able to hold one
of the intermediate states.

So I'm generally in favour of this change (as a general point, given
case folding issues and the like, I'm for any change that avoids
relying on the dirstate if it's not needed).

Paul.


More information about the Mercurial-devel mailing list