[PATCH 1 of 3] convert: cvsps.py - code to generate changesets from a CVS repository

Frank A. Kingswood frank at kingswood-consulting.co.uk
Mon Jun 16 12:08:30 CDT 2008

Matt Mackall wrote:
> On Sun, 2008-06-15 at 17:19 +0100, Frank Kingswood wrote:
>> +        e.Changeset = c
>> +        c.entries.append(e)
> What's going on here? First we've got "Changeset" that doesn't appear
> anywhere else, and then we've got a circular data structure? There also
> aren't any other uses of x.changeset that I can see either?
Yes, that member is unused, except for debug, and it can be removed safely.
Recursive datastructures rock.

Looking further, it appears to be the only capitalized member in 
cvsps.py and cvs.py - although some remain in cvsps, hope that's OK.

I have removed it and verified that my testcases still run OK.


Frank A. Kingswood                      frank at kingswood-consulting.co.uk
Cambridge, United Kingdom                               +44-7943-217 571

More information about the Mercurial-devel mailing list