[RFC] branchview-NG

[Matt Mackall]

On Tue, 2008-06-17 at 14:48 +0200, Dirkjan Ochtman wrote:
> As some of you may have noticed, I've been working on an update for the 
> old branchview extension. Matt mentioned he liked the idea save for some 
> crappy implementation details, so I've been trying to reimplement the 
> idea without all of the crap that came with the old implementation. This 
> work is now more or less finished, so I was wondering if this could now 
> be included in mainline Mercurial as an addition to the web interface.

This is looking very promising and addresses basically all of my issues
with the initial branchview! Some initial comments:

The json filter ought to be more generic, and in templatefilters, I
think.

The scroll/more/less buttons aren't in keeping with how other log pages
work.

How does graphmod relate to glog?

There seems to be an off-by one with diagonal line positioning. They
appear to come out of the top of nodes rather than the center.

At least with coal, the changeset text and style is not in keeping with
the style of the shortlog. Tags are missing.

We'll probably eventually want to color by branch name rather than
randomly.

It should also be possible to stylize the drawing per style. For
instance, I might want a style that does only gray lines with black
squares or diamonds. Or maybe draw it like subway map. Etc. That should
be as simple as putting a pair of node/edge javascript callback
functions in the page template, no?

Ok, now on to wishful thinking: I can imagine a button on the shortlog
page that toggles on a new column with the graph so that a separate page
isn't required.

-- 
Mathematics is the supreme nostalgia of our time.