[RFC] branchview-NG

[Matt Mackall]

On Tue, 2008-06-17 at 21:43 +0200, Dirkjan Ochtman wrote:
> Matt Mackall wrote:
> > I think a reasonable JSON encoder can be something like 20-30 lines.
> 
> Right. I added one this time around.

Looks ok.

> > Ok, you should probably update glog to use graphmod then.
> 
> glog is seriously hairy and I'd like to ask Joel Rosdahl to take a look 
>   before I spend a lot of time on it. I also think that, while I want to 
> push consolidation, this shouldn't stop us from merging the graph.

Sure.

> > - it should probably say "graph" rather than "revision graph"
>  > - it uses a really long date
>  > - it uses the full username
>  > - it's missing the thin ruling lines
> 
> Fixed all of these to be more consistent with shortlog.

Good.

> > - it shows the hash (which would probably be better as a tooltip here
> > and in shortlog)
> 
> I kept the hash because I wanted something which I could color; I 
> couldn't use the description for that because I wanted to make that link 
> to the actual changeset. I'm certainly interested in other ideas.

I'd think the row coloring would be sufficient here, but...

> > - it doesn't have the row coloring (maybe with good reason, but I'd
> > like to see them)
> 
> I didn't see this in shortlog, either. I also think it's not a good fit 
> with the other coloring we have going on. But you're welcome to experiment.

Really? Perhaps they're too pale on your display?

> > Maybe. But at any rate, it should be seen as an alternate view of the
> > shortlog. In particular, it should have changeset and browse buttons.
> > Toggling between log and graph should change as little as possible,
> > visually, at least in the coal and paper styles. That may even mean
> > dropping the author and date in this view (or moving them to tool tips)
> > so that everything is one line high.
> 
> I put in changeset and browse buttons. With the shortened user and date, 
> I think we don't need to move them into a tooltip, as it looks much less 
> cluttered now and is very nice on the eyes.

Yes, now there's only that big ugly hash to worry about. Perhaps move it
to the small text?

> > Also, FYI, I'm intending to make paper the default theme.
> 
> I thought as much. I think having the menu on the left is certainly
> an 
> improvement (and we should do that for coal, as well), but I think
> paper 
> is a little to grey for my taste currently.

I'm hoping more people will take a stab at making themes, now that there
are four examples in the tree. Hopefully the monoblue theme will show up
as a patch sometime soon and we'll have 5.

-- 
Mathematics is the supreme nostalgia of our time.