[RFC] branchview-NG

Dirkjan Ochtman dirkjan at ochtman.nl
Tue Jun 17 16:05:37 CDT 2008


Matt Mackall wrote:
> Great. There's one visual glitch left, which is that there's whitespace
> between the ruling lines and the canvas. Other than that, I'd say it's
> ready to merge.

Fixed this.

> Oh, one other little glitch.. the part of the description where the hash
> was isn't clickable.

Ah... That's a bit of a problem. Before, I had the ul layed out on top 
of the canvas. To get the row coloring right, I changed it around so 
that the ul is on the bottom with the canvas on top (otherwise the 
background color obscures the canvas). Apparently, the canvas makes the 
links unclickable. This only affects the left part because the canvas 
isn't as wide as the ul. At this point, there are 2 solutions:

- Draw rectangles on the canvas for each row. a little ugly, because 
it's bad for performance, and might be brittle because it has to match 
up very close with the height of the actual list items.

- Use two lists: one that has the background coloring, below the canvas, 
and one that has the text, above the canvas.

Both seem pretty ugly. Any better ideas?

Cheers,

Dirkjan



More information about the Mercurial-devel mailing list