patch to support multiple line keyword expansion

Tobias Sargeant tobias.sargeant at gmail.com
Wed Jun 18 04:31:42 CDT 2008


On 18/06/2008, at 6:27 PM, Christian Ebert wrote:
>
> Some -- biased, as I wrote keyword.py -- feedback:

[snip]

Thanks for the feedback. I wasn't really expecting that the patch
would be accepted as is, and I agree now that it can be
done (with a little more work) using encode/decode filters. I
asked whether there was any way of doing this on #mercurial
before I started modifying keyword.py, and that method wasn't
mentioned.

I'm happy to rework the patch to address the issues you raised,
but if you're disinclined to accept it on principle, then I'm
happy to let it drop.

Regards,
Toby.


More information about the Mercurial-devel mailing list