patch to support multiple line keyword expansion

Christian Ebert blacktrash at gmx.net
Wed Jun 18 05:23:06 CDT 2008


* Tobias Sargeant on Wednesday, June 18, 2008 at 19:31:42 +1000
> Thanks for the feedback. I wasn't really expecting that the patch
> would be accepted as is, and I agree now that it can be
> done (with a little more work) using encode/decode filters. I
> asked whether there was any way of doing this on #mercurial
> before I started modifying keyword.py, and that method wasn't
> mentioned.
> 
> I'm happy to rework the patch to address the issues you raised,
> but if you're disinclined to accept it on principle, then I'm
> happy to let it drop.

I'm not in a position to accept it; others might chime in whether
multiline epansions are to be desired. In my earlier reply I
outlined why I tend to not incorporating this in keyword.py.
Safety and speed issues aside I guess one could describe the main
task of the extension to write changeset specific information
into files of the working dir; for the purpose you described
(inserting a static string /repowise/ not filewise and changeset
specific) most of the code gymnastics of the extension are not
needed. -- But it might very well be that my pov is too narrow
due to personal usage preferences. 

c
-- 
  Was heißt hier Dogma, ich bin Underdogma!
[ What the hell do you mean dogma, I am underdogma. ]

_F R E E_  _V I D E O S_  -->>  http://www.blacktrash.org/underdogma/


More information about the Mercurial-devel mailing list