[PATCH] W3C validation

Tue Jun 24 17:49:19 CDT 2008

With this patch every pages of coal and paper pass fine ... except ...
graph with its canvas trick.

On Wed, Jun 25, 2008 at 00:46, Ben <benoit.allard at gmx.de> wrote:
> # HG changeset patch
> # User Benoit Allard <benoit at aeteurope.nl>
> # Date 1214347322 -7200
> # Node ID 1506af27dca73c15a9c857190372b278c7c5df87
> # Parent  1fe6f365df2e0ed6dd56b5bd9993812378506174
> paper/coal: W3C validation
>
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/changeset.tmpl
> --- a/templates/coal/changeset.tmpl     Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/changeset.tmpl     Wed Jun 25 00:42:02 2008 +0200
> @@ -18,7 +18,8 @@
>  <li><a href="{url}file/{node|short}{sessionvars%urlparameter}">browse</a></li>
>  </ul>
>  <ul>
> - {archives%archiveentry}</ul>
> + {archives%archiveentry}
> +<li><!-- placeholder--></li>
>  </ul>
>  </div>
>
> @@ -41,7 +42,8 @@
>  </tr>
>  <tr>
>  <th class="date">date</th>
> - <td class="date">{date|date} ({date|age} ago)</td></tr>
> + <td class="date">{date|date} ({date|age} ago)</td>
> +</tr>
>  <tr>
>  <th class="author">parents</th>
>  <td class="author">{parent%changesetparent}</td>
> @@ -52,10 +54,9 @@
>  </tr>
>  <tr>
>  <th class="files">files</th>
> - <td class="files">{files}</td></tr>
> + <td class="files">{files}</td>
>  </tr>
>  </table>
> -<tr>
>
>  <div class="overflow">
>  <table class="bigtable">
> @@ -67,6 +68,7 @@
>  {diff}
>  </div>
>  </div>
> +</div>
>  {footer}
>
>
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/fileannotate.tmpl
> --- a/templates/coal/fileannotate.tmpl  Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/fileannotate.tmpl  Wed Jun 25 00:42:02 2008 +0200
> @@ -30,7 +30,7 @@
>
>  <div class="main">
>  <h2>{repo|escape}</h2>
> -<h3>annotate {file|escape} @ {rev}:{node|short}</h2>
> +<h3>annotate {file|escape} @ {rev}:{node|short}</h3>
>
>  <form class="search" action="{url}log">
>  {sessionvars%hiddenformentry}
> @@ -59,7 +59,7 @@
>  {changesettag}
>  </table>
>
> -<br/>
> +<br>
>
>  <div class="overflow">
>  <table class="bigtable">
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/filediff.tmpl
> --- a/templates/coal/filediff.tmpl      Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/filediff.tmpl      Wed Jun 25 00:42:02 2008 +0200
> @@ -64,7 +64,7 @@
>  <th class="lineno">line</th>
>  <th class="source">diff</th>
>  </tr>
> -<table>
> +</table>
>  {diff}
>  </div>
>  </div>
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/filelog.tmpl
> --- a/templates/coal/filelog.tmpl       Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/filelog.tmpl       Wed Jun 25 00:42:02 2008 +0200
> @@ -4,7 +4,6 @@
>    href="{url}atom-log/tip/{file|urlescape}" title="Atom feed for
> {repo|escape}:{file}">
>  <link rel="alternate" type="application/rss+xml"
>    href="{url}rss-log/tip/{file|urlescape}" title="RSS feed for
> {repo|escape}:{file}">
> -</head>
>  </head>
>  <body>
>
> @@ -46,9 +45,9 @@
>
>  <table class="bigtable">
>  <tr>
> -  <th class="age">age</td>
> -  <th class="author">author</td>
> -  <th class="description">description</td>
> +  <th class="age">age</th>
> +  <th class="author">author</th>
> +  <th class="description">description</th>
>  </tr>
>  {entries%filelogentry}
>  </table>
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/graph.tmpl
> --- a/templates/coal/graph.tmpl Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/graph.tmpl Wed Jun 25 00:42:02 2008 +0200
> @@ -40,16 +40,17 @@
>  | {changenav%navgraphentry}
>  </div>
>
> -<div id="noscript">The revision graph only works with
> JavaScript-enabled browsers.</div>
> +<div id="noscript">
> +The revision graph only works with JavaScript-enabled browsers.</div>
>
>  <div id="wrapper">
> -<ul id="nodebgs"></ul>
> +<ul id="nodebgs"><li></li></ul>
>  <canvas id="graph" width="224" height="{canvasheight}"></canvas>
> -<ul id="graphnodes"></ul>
> +<ul id="graphnodes"><li></li></ul>
>  </div>
>
>  <script type="text/javascript" src="{staticurl}graph.js"></script>
> -<script>
> +<script type="text/javascript">
>
>  document.getElementById('noscript').style.visibility = 'hidden';
>
> @@ -68,12 +69,14 @@
>  }
>
>  var nodes = document.getElementById('graphnodes');
> +nodes.innerHTML = '';
>  var nodebgs = document.getElementById('nodebgs');
> +nodebgs.innerHTML = '';
>
>  var revlink = '<li style="_STYLE"><span class="desc">';
> -revlink += '<a href="{url}rev/_NODEID{sessionvars%urlparameter}"
> title="_NODEID">_DESC</a>';
> -revlink += '</span><span class="tag">_TAGS</span>';
> -revlink += '<span class="info">_DATE ago, by _USER</span></li>';
> +revlink += '<a href="{url}rev/_NODEID{sessionvars%urlparameter}"
> title="_NODEID">_DESC<\/a>';
> +revlink += '<\/span><span class="tag">_TAGS<\/span>';
> +revlink += '<span class="info">_DATE ago, by _USER<\/span><\/li>';
>
>  graph.vertex = function(x, y, color, parity, cur) {
>
> @@ -82,7 +85,7 @@
>        this.ctx.arc(x, y, radius, 0, Math.PI * 2, true);
>        this.ctx.fill();
>
> -       var bg = '<li class="bg parity' + parity + '"></li>';
> +       var bg = '<li class="bg parity' + parity + '"><\/li>';
>        nodebgs.innerHTML += bg;
>
>        var left = (this.columns + 1) * this.bg_height;
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/header.tmpl
> --- a/templates/coal/header.tmpl        Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/header.tmpl        Wed Jun 25 00:42:02 2008 +0200
> @@ -3,5 +3,5 @@
>  <html>
>  <head>
>  <link rel="icon" href="{staticurl}hgicon.png" type="image/png">
> -<meta name="robots" content="index, nofollow" />
> -<link rel="stylesheet" href="{staticurl}style-coal.css" type="text/css" />
> +<meta name="robots" content="index, nofollow" >
> +<link rel="stylesheet" href="{staticurl}style-coal.css" type="text/css" >
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/manifest.tmpl
> --- a/templates/coal/manifest.tmpl      Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/manifest.tmpl      Wed Jun 25 00:42:02 2008 +0200
> @@ -20,6 +20,7 @@
>  </ul>
>  <ul>
>  {archives%archiveentry}
> +<li><!-- placeholder--></li>
>  </ul>
>  </div>
>
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/map
> --- a/templates/coal/map        Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/map        Wed Jun 25 00:42:02 2008 +0200
> @@ -22,8 +22,8 @@
>  changeset = changeset.tmpl
>  manifest = manifest.tmpl
>
> -direntry = '<tr class="fileline parity{parity}"><td class="name"><a
> href="{url}file/{node|short}{path|urlescape}{sessionvars%urlparameter}"><img
> src="{staticurl}coal-folder.png"> {basename|escape}/</a><td
> class="size"></td><td class="permissions">drwxr-xr-x</td></tr>'
> -fileentry = '<tr class="fileline parity{parity}"><td
> class="filename"><a
> href="{url}file/{node|short}/{file|urlescape}{sessionvars%urlparameter}#l1"><img
> src="{staticurl}coal-file.png"> {basename|escape}</a></td><td
> class="size">{size}</td><td
> class="permissions">{permissions|permissions}</td></tr>'
> +direntry = '<tr class="fileline parity{parity}"><td class="name"><a
> href="{url}file/{node|short}{path|urlescape}{sessionvars%urlparameter}"><img
> src="{staticurl}coal-folder.png" alt="dir"> {basename|escape}/</a><td
> class="size"></td><td class="permissions">drwxr-xr-x</td></tr>'
> +fileentry = '<tr class="fileline parity{parity}"><td
> class="filename"><a
> href="{url}file/{node|short}/{file|urlescape}{sessionvars%urlparameter}#l1"><img
> src="{staticurl}coal-file.png" alt="file">
> {basename|escape}</a></td><td class="size">{size}</td><td
> class="permissions">{permissions|permissions}</td></tr>'
>
>  filerevision = filerevision.tmpl
>  fileannotate = fileannotate.tmpl
> @@ -67,4 +67,4 @@
>  notfound = notfound.tmpl
>  error = error.tmpl
>  urlparameter = '{separator}{name}={value|urlescape}'
> -hiddenformentry = '<input type="hidden" name="{name}"
> value="{value|escape}" />'
> +hiddenformentry = '<input type="hidden" name="{name}" value="{value|escape}" >'
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/coal/shortlog.tmpl
> --- a/templates/coal/shortlog.tmpl      Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/coal/shortlog.tmpl      Wed Jun 25 00:42:02 2008 +0200
> @@ -24,6 +24,7 @@
>  </ul>
>  <ul>
>  {archives%archiveentry}
> +<li><!-- placeholder--></li>
>  </ul>
>  </div>
>
> @@ -40,10 +41,10 @@
>  <div class="navigate">rev {rev}: {changenav%navshortentry}</div>
>
>  <table class="bigtable">
> - <tr>
> -  <th class="age">age</td>
> -  <th class="author">author</td>
> -  <th class="description">description</td>
> + <tr>
> +  <th class="age">age</th>
> +  <th class="author">author</th>
> +  <th class="description">description</th>
>  </tr>
>  {entries%shortlogentry}
>  </table>
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/paper/header.tmpl
> --- a/templates/paper/header.tmpl       Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/paper/header.tmpl       Wed Jun 25 00:42:02 2008 +0200
> @@ -3,5 +3,5 @@
>  <html>
>  <head>
>  <link rel="icon" href="{staticurl}hgicon.png" type="image/png">
> -<meta name="robots" content="index, nofollow" />
> -<link rel="stylesheet" href="{staticurl}style-paper.css" type="text/css" />
> +<meta name="robots" content="index, nofollow">
> +<link rel="stylesheet" href="{staticurl}style-paper.css" type="text/css">
> diff -r 1fe6f365df2e -r 1506af27dca7 templates/paper/map
> --- a/templates/paper/map       Mon Jun 23 15:02:52 2008 +0200
> +++ b/templates/paper/map       Wed Jun 25 00:42:02 2008 +0200
> @@ -22,8 +22,8 @@
>  changeset = ../coal/changeset.tmpl
>  manifest = ../coal/manifest.tmpl
>
> -direntry = '<tr class="fileline parity{parity}"><td class="name"><a
> href="{url}file/{node|short}{path|urlescape}{sessionvars%urlparameter}"><img
> src="{staticurl}coal-folder.png"> {basename|escape}/</a><td
> class="size"></td><td class="permissions">drwxr-xr-x</td></tr>'
> -fileentry = '<tr class="fileline parity{parity}"><td
> clase="filename"><a
> href="{url}file/{node|short}/{file|urlescape}#l1{sessionvars%urlparameter}"><img
> src="{staticurl}coal-file.png"> {basename|escape}</a></td><td
> class="size">{size}</td><td
> class="permissions">{permissions|permissions}</td></tr>'
> +direntry = '<tr class="fileline parity{parity}"><td class="name"><a
> href="{url}file/{node|short}{path|urlescape}{sessionvars%urlparameter}"><img
> src="{staticurl}coal-folder.png" alt="dir"> {basename|escape}/</a><td
> class="size"></td><td class="permissions">drwxr-xr-x</td></tr>'
> +fileentry = '<tr class="fileline parity{parity}"><td
> class="filename"><a
> href="{url}file/{node|short}/{file|urlescape}#l1{sessionvars%urlparameter}"><img
> src="{staticurl}coal-file.png" alt="file">
> {basename|escape}</a></td><td class="size">{size}</td><td
> class="permissions">{permissions|permissions}</td></tr>'
>
>  filerevision = ../coal/filerevision.tmpl
>  fileannotate = ../coal/fileannotate.tmpl
>