[issue1199] hg clone with '@' in http username

Matt Mackall mpm at selenic.com
Wed Jun 25 12:17:11 CDT 2008


On Wed, 2008-06-25 at 09:17 -0400, Jonathan S. Shapiro wrote:
> On Wed, 2008-06-25 at 00:59 +0000, Michael Cahill wrote:
> > Our group has email addresses as https usernames, so they contain '@'...
> 
> I believe that this usage does not constitute a well-formed https URL.
> The traditional solution to this sort of "@ within @" problem would be
> to use something like:
> 
>   http://mjc%example.com@hg.example.com/
> 
> but of course '%' must be escaped.
> 
> In any case, we should check the well-formedness issue before accepting
> any patch to support this behavior. If the URL you want to use is
> malformed, hg should NOT (in my opinion) support it.
> 
> My concern is mainly that URLs are badly underspecified, which makes
> parsers for them crufty things already. Gunking up that code further to
> support malformed cases (if this is one) doesn't seem like a good idea.

On the other hand, all the URL parsing logic in hg is working for them
already. What's not working is our config file parser which has stupid
ideas about what % means.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list