[PATCH 0 of 6] Fix problems found by Pyflakes

Joel Rosdahl joel at rosdahl.net
Wed Mar 5 00:07:58 CST 2008


Bryan O'Sullivan <bos at serpentine.com> writes:

> Joel Rosdahl wrote:
>
>> A possibly controversial thing about the first patch is that it
>> removes the import of everything in mercurial.node/mercurial.repo
>> from mercurial/hg.py, which means that
>> mercurial.node/mercurial.repo stuff won't be importable from
>> mercurial.hg anymore.
>
> What's the reason for this? It seems to make the patch much more
> intrusive, without providing any benefit in readability.

I think I had two reasons: Because that's what I personally would have
wanted ("a given name should only be imported from the module where it
logically belongs") and because Pyflakes otherwise would point out
that the imported mercurial.node/mercurial.repo names in
mercurial/hg.py are unused. But neither reason is strong. I can create
an alternative patch if wanted; no problem.

> Aside from this consideration, your changes introduce 8 new test
> failures:
>
> test-convert-hg-svn.err
> test-convert-svn-branches.err
> test-convert-svn-move.err
> test-convert-svn-sink.err
> test-convert-svn-source.err
> test-convert-svn-startrev.err

Yes, sloppy of me to not install the svn bindings before testing.
Sorry. Will fix.

> test-convert-cvs.err
> test-fetch.err

Huh? Works for me.

Regards,
Joel

-- 
Joel Rosdahl <joel at rosdahl.net>
Key BB845E97; fingerprint 9F4B D780 6EF4 5700 778D  8B22 0064 F9FF BB84 5E97


More information about the Mercurial-devel mailing list