patch: monotone source for mercurial convert extension

Mikkel Fahnøe Jørgensen mikkel at dvide.com
Tue Mar 25 11:38:14 CDT 2008


> Patrick Mézard:
> FYI, the original converter did not record file removal. I don't know if the issue was
> already in your submission or came during the integration but it's fixed by now.

I think it was something I happened to voice my opinion about :-)
There was no direct delete support when I wrote the code, but my
converter does handle rename and deletion (based on one other
converter doing something similar - svn I think). Deletion works as
follows: the driver logic assumes file delete in hg when get file
fails in the converter object. The converter should then try to only
generate errors for deleted files. In monotone->hg this is handled by
caching a list of known files and directories. There is a slight twist
on this, since hg doesn't track directories directly and in monotone a
directory might be deleted, or renamed thereby complicating the
conversion logic, but this ought to be handled correctly.

I don't know if delete handling has been made more explicit, or you
refer to an earlier state where delete was not at all possible.

Mikkel



More information about the Mercurial-devel mailing list