[issue1056] convert/git: Only append committer to message if different from author

[Thomas Arendsen Hein]

New submission from Thomas Arendsen Hein <thomas at intevation.de>:

Maximilian Gaß <mxey at cloudconnected.org> sent me the attached patch.

I consider it a minor bug to always add the committer to the changelog message,
even if it is identical to the author, so I'm tempted to push it to crew-stable
after fixing the case of committer or author not set or "unknown" (or whatever
git presents us here.

Would it be suitable for -stable?
Or should the current behavior be preserved, even if it is annoying?
Should it even be configurable? (I'd say no)

See e.g. http://hg.intevation.org/mirrors/vireo.org/tritium/rev/4b01ab8f7bc8
for an example of this duplication.

What should happen exactly if author or committer is unknown?

----------
assignedto: ThomasAH
files: convert-git-committer-in-message.diff
messages: 5751
nosy: ThomasAH, bos, brendan, mpm, pmezard, tonfa
priority: bug
status: unread
title: convert/git: Only append committer to message if different from author
topic: convert, patch

____________________________________________________
Mercurial issue tracker <mercurial-bugs at selenic.com>
<http://www.selenic.com/mercurial/bts/issue1056>
____________________________________________________
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: convert-git-committer-in-message.diff
Url: http://selenic.com/pipermail/mercurial-devel/attachments/20080331/f30baa67/attachment.txt