allow to specify bundle type
dirkjan at ochtman.nl
Wed May 7 09:36:10 CDT 2008
On Wed, May 7, 2008 at 4:00 PM, Benoît Allard <benoit at aeteurope.nl> wrote:
> Hey, pssssttt, there was a patch there ... ;-)
> Any objections / improvements to it ?
For one thing, it's probably too big. Split it up into patches that do
one thing, please.
For another, I still don't like the try: except KeyError: idiom. It's
not just an item access in there, but also some trickery with default
values, lowercasing, and it takes more lines than necessary. So just
use the 'in' operator as it's intended.
Please use a space after a comma.
I tend to prefer single quotes over double quotes for small, simple
strings (like in typealias).
Put typealias after bundletypes, not before it.
More information about the Mercurial-devel