[PATCH] Updated *sh://host... patch

Peter Kourzanov peter.kourzanov at nxp.com
Tue May 20 05:34:41 CDT 2008


Benoit,

  It is a little strange to specify --ssh=rsh ssh://host/path... Isn't it
much more precise and consistent to
just use rsh://host/path?

  Nevertheless, I can work on submission of a patch that will have --ssh
override the *sh:// specification,
if there is any chance of getting it in the mainline.

Regards,

Pjotr


                                                                           
                                                                           
                                                                           
                                                                        To 
                                       "Pjotr Kourzanov"                   
                                       <peter.kourzanov at xs4all.nl>         
     "Benoit Boissinot"                                                 cc 
     <bboissin at gmail.com>              "Pjotr Kourzanov"                   
                                       <peter.kourzanov at nxp.com>,          
     05/20/2008 12:02 PM               mercurial-devel at selenic.com         
                                                                   Subject 
                                       Re: [PATCH] Updated *sh://host...   
                                       patch                               
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




2008/3/21 Pjotr Kourzanov <peter.kourzanov at xs4all.nl>:
> Patch subject is complete summary.
>
>
> 2 files changed, 14 insertions(+), 8 deletions(-)
> mercurial/hg.py      |    9 +++++++--
> mercurial/sshrepo.py |   13 +++++++------
>

(Can you try to send the messages inline ?)

About your patch, is there a reason why you can't use the --ssh
(or ui.ssh in .hgrc) option ?

> -        sshcmd = self.ui.config("ui", "ssh", "ssh")
> +        # TODO bogus: sshcmd = self.ui.config("ui", "ssh", "ssh")
> +        sshcmd = m.group(1)
In any case if this patch goes in, it needs to continue to support --ssh.

regards,

Benoit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://selenic.com/pipermail/mercurial-devel/attachments/20080520/9e8060e0/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20080520/9e8060e0/attachment.gif 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pic12859.gif
Type: image/gif
Size: 1255 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20080520/9e8060e0/attachment-0001.gif 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ecblank.gif
Type: image/gif
Size: 45 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20080520/9e8060e0/attachment-0002.gif 


More information about the Mercurial-devel mailing list