Possibly ignorable test failure?

Dirkjan Ochtman dirkjan at ochtman.nl
Tue May 20 17:02:37 CDT 2008

Paul Moore <p.f.moore <at> gmail.com> writes:
> I can fix this, but it involves writing a chunk of ugly
> string-manipulation code (as none of the os.path functions give me a
> way of doing this). The question is, should I do so? In my view, the
> tests are incorrect, as they check for exact string matches of the
> output, rather than working on functional equivalence, but that's the
> way they are and I'm not about to change that. So should the core code
> pay the cost (a small performance cost and a somewhat larger
> maintainability cost) to keep the tests happy?

I think in this case changing the test output would be just fine. If the paths
are still correct (and in fact, closer to what Windows users are used to), that
seems like an improvement to me, and certainly not reason to bloat the core.



More information about the Mercurial-devel mailing list