[SoC] Rebase feature - Nested revisions

Javier Merino cibervicho at gmail.com
Sat May 31 05:46:01 CDT 2008


2008/5/31 Christian Ebert wrote:
> * Javier Merino on Saturday, May 31, 2008 at 12:17:09 +0200
>> 2008/5/31 Christian Ebert wrote:
>>> Depending on context, one could simply use
>>> cmdutil.bail_if_changed instead.
>>
>> Yes, it is much better.
>
> Unless you would need the result of repo.status later or had
> called repo.status already before.

But I think that's not the case here. It was just a check to make
rebase complain if it found local changes. My previous patch added a
new function to do that, but that function already existed. The
repo.status is not needed before the hg.clean(). Besides, this makes
it fail with the more familiar "outstanding uncommited changes".

Thanks for the info,
Javi


More information about the Mercurial-devel mailing list