[PATCH] bookmarks: do nothing if commit was not successful

sn_ sn_ at gmx.net
Thu Nov 6 17:02:16 CST 2008


I'll include a fix for that in the next pull request, but actually I don't care that much about that and want to leave that the way it is.

-------- Original-Nachricht --------
> Datum: Thu, 6 Nov 2008 14:15:48 +0100
> Von: "Benoit Boissinot" <bboissin at gmail.com>
> An: "Dmitriy Taychenachev" <dimichxp at gmail.com>, mercurial-devel at selenic.com
> Betreff: Re: [PATCH] bookmarks: do nothing if commit was not successful

> On Wed, Nov 5, 2008 at 10:13 PM, Dennis Brakhane
> <brakhane at googlemail.com> wrote:
> > On Sun, Oct 26, 2008 at 05:10:44PM +0800, Dmitriy Taychenachev wrote:
> >> +            if node == None:
> >> +                return None
> >
> > Shouldn't that be "if node is None"?
> 
> Both forms are correct, I find the later one prettier :)
> 
> regards,
> 
> Benoit
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

-- 
GMX Download-Spiele: Preizsturz! Alle Puzzle-Spiele Deluxe über 60% billiger.
http://games.entertainment.gmx.net/de/entertainment/games/download/puzzle/index.html


More information about the Mercurial-devel mailing list